Open
Conversation
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new MonthPicker component to the frappe-ui-react component library. The component allows users to select a month and year through an interactive popover interface with navigation controls.
Changes:
- Added MonthPicker component with month and year selection functionality
- Implemented Storybook stories for component documentation
- Created TypeScript type definitions for component props
- Added barrel exports for the new component
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| packages/frappe-ui-react/src/components/monthPicker/monthPicker.tsx | Main component implementation with popover-based UI, month/year view modes, and navigation controls |
| packages/frappe-ui-react/src/components/monthPicker/types.ts | TypeScript interface defining component props including value, placement, and onChange callback |
| packages/frappe-ui-react/src/components/monthPicker/index.ts | Barrel exports for the MonthPicker component and its types |
| packages/frappe-ui-react/src/components/monthPicker/monthPicker.stories.tsx | Storybook stories demonstrating default and fit-width variants |
packages/frappe-ui-react/src/components/monthPicker/monthPicker.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/monthPicker/monthPicker.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/monthPicker/monthPicker.tsx
Outdated
Show resolved
Hide resolved
packages/frappe-ui-react/src/components/monthPicker/monthPicker.tsx
Outdated
Show resolved
Hide resolved
4 tasks
Collaborator
|
@ayushnirwal this PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add component month picker
Screenshot/Screencast
Screen.Recording.2026-02-05.at.4.32.48.PM.mov
Checklist